Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP referer to rack integration #197

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

bgitt
Copy link
Contributor

@bgitt bgitt commented Mar 18, 2022

This will be helpful to determine where requests are coming from in our application.

Co-Authored-by: Marcelo Guindon marcelo@modeanalytics.com

@bgitt bgitt requested a review from a team March 18, 2022 21:58
@bgitt bgitt requested a review from martin308 as a code owner March 18, 2022 21:58
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @bgitt & @monteverdetico! Referer would be useful telemetry.

This looks great! I only suggest that an obviously made-up URL be used in the test cases.

spec/honeycomb/integrations/rack_spec.rb Outdated Show resolved Hide resolved
spec/honeycomb/integrations/rails_spec.rb Outdated Show resolved Hide resolved
@robbkidd robbkidd added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. status: revision needed Waiting for response to changes requested. and removed status: revision needed Waiting for response to changes requested. labels Mar 24, 2022
bgitt and others added 2 commits March 28, 2022 11:00
Co-Authored-by: Marcelo Guindon <marcelo@modeanalytics.com>
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the referral!

@robbkidd robbkidd merged commit 5898c92 into honeycombio:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants