maint: fix nightly build #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmock 3.17.0 is no longer compatible with ruby 2.2
vreynolds
added
type: maintenance
robbkidd
approved these changes
Aug 8, 2022
honeycomb-beeline.gemspec
Outdated
| @@ -52,5 +52,6 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency "rubocop-performance", "< 1.3.0" | |||
| spec.add_development_dependency "simplecov" | |||
| spec.add_development_dependency "simplecov-console" | |||
| spec.add_development_dependency "webmock" | |||
| webmock_version = RUBY_VERSION < "2.3.0" ? "< 3.15.0" : nil | |||
| spec.add_development_dependency "webmock", webmock_version | |||
There was a problem hiding this comment.
It only makes my brain itch a little bit. I might offer the more verbose rendition of this because ternaries make my eyes cross sometimes:
if RUBY_VERSION < "2.3.0"
spec.add_development_dependency "webmock", "< 3.15.0"
else
spec.add_development_dependency "webmock"
endBut my brain itches are not blockers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes