Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set min rubocop to avoid false positive lint error #218

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

robbkidd
Copy link
Member

@robbkidd robbkidd commented Jan 3, 2023

Which problem is this PR solving?

v0.60.0 includes a fix (6331) for false positives on Regexes assigned to a constant that will quiet the lint error that's appeared in nightly.

Less than v0.69.0 remains for Ruby 2.2 until a time that we decide to overhaul and update dev/test.

v0.60.0[1] includes a fix (6331) for false positives on Regexes assigned
to a constant that will quiet the lint error that's appeared in nightly.

Less than v0.69.0 remains for Ruby 2.2 until a time that we decide to
overhaul and update dev/test.

[1] https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0600-2018-10-26
@robbkidd robbkidd requested a review from a team January 3, 2023 00:17
@robbkidd robbkidd added type: bug Something isn't working version: no bump A PR with maintenance or doc changes that aren't included in a release. status: oncall Flagged for awareness from Honeycomb Telemetry Oncall no-changelog Omit this PR from changelog/release notes. labels Jan 3, 2023
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint

@robbkidd robbkidd merged commit 66e8561 into main Jan 3, 2023
@robbkidd robbkidd deleted the robb.quiet-lint-false-positive-re-frozen-res branch January 3, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Omit this PR from changelog/release notes. status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: bug Something isn't working version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants