maint: update AWS credendtials workflow step from v1 -> v4

[MikeGoldsmith]

Which problem is this PR solving?

Updates the AWS configure step used in the validate template workflow to use a newer version as v1 is now deprecated.

Short description of the changes

• Update configure-aws-credentials step to use v4

How to verify that this has the expected result

The workflow can now complete as it's using a supported version.

[JamieDanielson]

Do we also need to update this in the publish-templates.yaml workflow?

[dougireton]

Maybe you want to update actions/checkout to v4 as well?

https://github.com/search?q=repo:honeycombio/cloudformation-integrations%20actions/checkout&type=code

[JamieDanielson]

Hm, so it looks like the failed check from the other PR is actually on the publish-templates workflow based on the job action run - not the validate workflow. And I don't think it's because of the deprecated action. The failure is in Configure AWS Credentials, which includes a secret. The workflow sets pull_request, not pull_request_target. The main difference between the two is that the secrets are not passed to the runner when a workflow is triggered from a forked repository. So I think the failure would be resolved if someone with write access on this repo committed a change to trigger that workflow.

Either way it's probably worth updating these actions - but I don't think that is the primary issue causing the checks to fail on the other PR.