maint: dockerize go services #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make it work again since switching to shared go.mod file - use non-alpine build container because we need git to resolve one of the deps - copy certs into bin container so we can talk to honeycomb
MikeGoldsmith
approved these changes
Jan 9, 2023
| @@ -1,10 +1,15 @@ | |||
| FROM golang:1.16-alpine AS build | |||
| FROM golang:1.18 AS build | |||
There was a problem hiding this comment.
Should we update to 1.19 not it's out?
There was a problem hiding this comment.
I think I picked 1.18 as "modern enough not to be obsolete, not so modern to cause issues"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes