Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable detection of gha-buildevents created spans #19

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Dec 14, 2020

This adds a meta.source top-level field to all events so that users can
easily distinguish between this and other sourced events.

This adds a `meta.source` top-level field to all events so that users can
easily distinguish between this and other sourced events.
@kvrhdn kvrhdn mentioned this pull request Dec 16, 2020
2 tasks
Copy link
Contributor

@kvrhdn kvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kvrhdn kvrhdn merged commit 3822dbd into honeycombio:main Dec 16, 2020
@kvrhdn
Copy link
Contributor

kvrhdn commented Dec 16, 2020

Okay, the CI has run and I see now the meta.source field is only added to the parent trace and the last span (the gha-buildevents_post). Since we only create buildevents.txt in the post section, up until then buildevents won't know about meta.source...

I'm not sure what the best solution is here:

  • we can create buildevents.txt at the beginning of the build, but then other programs should append their fields to this file (so gha-buildevents determines the location, the rest should follow)
  • we keep it as is, though it feels inconsistent...

I'm more in favor of the first option, would this work with your workflows @DavidS ?

@kvrhdn
Copy link
Contributor

kvrhdn commented Dec 16, 2020

I'll make a new release (and update the v1 tag) when we address this ☝🏻

@DavidS
Copy link
Contributor Author

DavidS commented Dec 17, 2020

I definitely approve of the idea of getting gha-buildevents to manage the BUILDEVENT_FILE earlier. With the changes in #18 this is not an issue for our workflows, as we're setting BUILDEVENT_FILE and pre-filling fields there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants