Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memory.utilization memory counter to use memory.workingset #242

Merged
merged 5 commits into from
Apr 5, 2022

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Mar 31, 2022

Which problem is this PR solving?

Updates the memory.utilization memory counter to based on memory.working_set.

Short description of the changes

  • Updates the memory.utilization measurement to use memory.workingset

@MikeGoldsmith MikeGoldsmith added type: bug version: bump minor A PR that adds behavior, but is backwards-compatible. labels Mar 31, 2022
@MikeGoldsmith MikeGoldsmith self-assigned this Mar 31, 2022
@MikeGoldsmith MikeGoldsmith requested a review from a team March 31, 2022 12:21
@vreynolds
Copy link
Contributor

should this count as a breaking change?

@puckpuck
Copy link
Contributor

puckpuck commented Apr 1, 2022

We should calculate working_set against the pod limits to compute the utilization metric, else we are breaking backward compatibility.

@MikeGoldsmith
Copy link
Contributor Author

Sure, we can add it in - the original issue suggested we may not need it. I'll look to re-add as suggesed.

@MikeGoldsmith MikeGoldsmith merged commit 07e9a09 into main Apr 5, 2022
@MikeGoldsmith MikeGoldsmith deleted the mike/remove-utilisation-calc branch April 5, 2022 14:01
@MikeGoldsmith MikeGoldsmith changed the title Remove memory.utilization memory counter Update memory.utilization memory counter to use memory.workingset Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node memory.utilization metric incorrect
3 participants