Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: Add labels to build #354

Merged
merged 1 commit into from
Mar 21, 2023
Merged

maint: Add labels to build #354

merged 1 commit into from
Mar 21, 2023

Conversation

TylerHelmuth
Copy link
Contributor

@TylerHelmuth TylerHelmuth commented Mar 21, 2023 •
edited

Which problem is this PR solving?

  • Adds labels to the built images

Short description of the changes

  • adds 3 new labels to the built images

Tested with personal credentials pushing to https://hub.docker.com/r/thelmuth34/honeycomb-kubernetes-agent/tags. Outcome of the labels from a docker inspect command looked like:

            "Labels": {
                "org.opencontainers.image.licenses": "Apache-2.0",
                "org.opencontainers.image.revision": "d721c5f1f30254d8f3a0658bf071675d59ccaa79",
                "org.opencontainers.image.source": "https://github.com/honeycombio/honeycomb-kubernetes-agent"
            }

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner March 21, 2023 18:49
@TylerHelmuth TylerHelmuth mentioned this pull request Mar 21, 2023
Merged
kentquirk
kentquirk approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TylerHelmuth TylerHelmuth merged commit 3592733 into main Mar 21, 2023
@TylerHelmuth TylerHelmuth deleted the tyler.add-labels-to-image branch March 21, 2023 22:31
TylerHelmuth added a commit to honeycombio/refinery that referenced this pull request Mar 22, 2023
@TylerHelmuth
maint: Add labels to docker image (#640)
9096a5b 
<!--
Thank you for contributing to the project! 💜
Please make sure to:
- Chat with us first if this is a big change
  - Open a new issue (or comment on an existing one)
- We want to make sure you don't spend time implementing something we
might have to say No to
- Add unit tests
- Mention any relevant issues in the PR description (e.g. "Fixes #123")

Please see our [OSS process
document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#)
to get an idea of how we operate.
-->

## Which problem is this PR solving?

- Adds labels to the built images

## Short description of the changes

- adds 3 new labels to the built images
- tested these additions in
honeycombio/honeycomb-kubernetes-agent#354. I
don't really want to run the same steps for Refinery since they are
risky and Refinery's build is more complicated so there is more risk of
publishing an incorrect image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TylerHelmuth @kentquirk