Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add real logging framework #69

Closed
MikeGoldsmith opened this issue Aug 14, 2023 · 2 comments · Fixed by #72
Closed

Add real logging framework #69

MikeGoldsmith opened this issue Aug 14, 2023 · 2 comments · Fixed by #72
Assignees
@robbkidd
Labels
type: enhancement New feature or request
Milestone
Trial with HNY Do...

Comments

@MikeGoldsmith
Copy link
Contributor

Logging is custom and we should use a real logging framework instead.
@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Aug 14, 2023
@robbkidd
Copy link
Member

I'm game to work on this one. Intend to add logrus and replace all of the existing poop-to-console fmt calls with it.

@robbkidd robbkidd self-assigned this Aug 15, 2023
@robbkidd robbkidd mentioned this issue Aug 15, 2023
Merged
1 task
@robbkidd
Copy link
Member

Opted for zerolog as a lower-resource logging option among those recommended by the logrus project which is itself in maintenance mode.

@vreynolds vreynolds added this to the Trial with HNY Dogfood milestone Aug 16, 2023
MikeGoldsmith added a commit that referenced this issue Aug 17, 2023
@robbkidd @MikeGoldsmith
feat: more better logging (#72)
2b20759 
## Which problem is this PR solving?

- Closes #69 

## Short description of the changes

- add zerolog as a fast, low-resource logging library (among those
recommended by logrus)
- structure our calls formerly to stdlib's `log` now to zerolog's `log`

TODO:

- [x] replace or remove all the `fmt.Printf()`s

## How to verify that this has the expected result

- Beyond "lookit the console", TBD

---------

Co-authored-by: Mike Goldsmth <goldsmith.mike@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robbkidd robbkidd

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
Trial with HNY Dogfood
Development

Successfully merging a pull request may close this issue.

feat: more better logging honeycombio/honeycomb-network-agent
3 participants
@robbkidd @MikeGoldsmith @vreynolds