Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix up time stuff #92

Closed
JamieDanielson opened this issue Aug 21, 2023 · 0 comments · Fixed by #95
Closed

fix up time stuff #92

JamieDanielson opened this issue Aug 21, 2023 · 0 comments · Fixed by #95
Assignees
@vreynolds
Labels
type: bug Something isn't working
Milestone
Trial with HNY Do...

Comments

@JamieDanielson
Copy link
Contributor

JamieDanielson commented Aug 21, 2023 •
edited
Loading

https://github.com/honeycombio/honeycomb-ebpf-agent/blob/380bc11f9f8476796800586dc30331846098920f/main.go#L133

// should have _ms appended and converted to ms
ev.AddField("httpEvent_handled_latency", time.Now().Sub(event.Timestamp))

// should be millseconds not microseconds
ev.AddField("duration_ms", event.Duration.Microseconds())
@JamieDanielson JamieDanielson added type: enhancement New feature or request type: bug Something isn't working and removed type: enhancement New feature or request labels Aug 21, 2023
@vreynolds vreynolds added this to the Trial with HNY Dogfood milestone Aug 21, 2023
@vreynolds vreynolds self-assigned this Aug 21, 2023
@vreynolds vreynolds mentioned this issue Aug 21, 2023
Merged
vreynolds added a commit that referenced this issue Aug 21, 2023
@vreynolds
fix: time units in telemetry (#95)
b7a36bd 
## Which problem is this PR solving?

- Closes #92 

## Short description of the changes

- use explicit time units in telemetry name
- use ms for time data

## How to verify that this has the expected result

- build & run
- explore latency and duration telemetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vreynolds vreynolds

Labels
type: bug Something isn't working
Projects
None yet
Milestone
Trial with HNY Dogfood
Development

Successfully merging a pull request may close this issue.

fix: time units in telemetry honeycombio/honeycomb-network-agent
2 participants
@vreynolds @JamieDanielson