Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: improve Makefile targets #176

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

robbkidd
Copy link
Member

Which problem is this PR solving?

  • We tinkered with this together yesterday. Figured I would clean it up and PR it.

Short description of the changes

  • break up load-test swarm target so individual steps could be run separately
  • add remake-style comments so that remake --tasks outputs help text

How to verify that this has the expected result

Run remake --tasks and see descriptions of what makey things we have.

- break up load-test swarm target so individual steps could be run
  separately
- add remake-style comments so that remake --tasks outputs help text
@robbkidd robbkidd requested a review from a team September 13, 2023 17:16
@robbkidd robbkidd added the type: maintenance The necessary chores to keep the dust off. label Sep 13, 2023
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this!

@MikeGoldsmith MikeGoldsmith merged commit e9d70a4 into main Sep 14, 2023
4 checks passed
@MikeGoldsmith MikeGoldsmith deleted the robb.makefile-improvements branch September 14, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants