fix: Close HTTP request & response body readers #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We are not closing parsed HTTP request or response correctly. We don't use them but not closing the reader correctly can lead to memory leaks as the underlying byte buffer is not released and garbage collected.
Short description of the changes
How to verify that this has the expected result
No functional changes as we're not using the HTTP request or response bodies. This should help reduce the amount of memory creep from byte[]'s that are not cleaned up correctly.