Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Remove unused source directory #198

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Sep 18, 2023

Which problem is this PR solving?

The code in source/ is duplicate of what's in assemblers/ so we should remove it.

Short description of the changes

  • Remove source/packet_source.go

How to verify that this has the expected result

Nothing, it was unused code. Running the agent should work the same as before this change.

@MikeGoldsmith MikeGoldsmith added the type: maintenance The necessary chores to keep the dust off. label Sep 18, 2023
@MikeGoldsmith MikeGoldsmith requested a review from a team September 18, 2023 12:31
@MikeGoldsmith MikeGoldsmith self-assigned this Sep 18, 2023
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the build completing successfully.

tenor-131255572

Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweep

@JamieDanielson JamieDanielson merged commit 57e1df0 into main Sep 19, 2023
3 checks passed
@JamieDanielson JamieDanielson deleted the mike/packet-source branch September 19, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants