fix: Reuse buffer in stream reader #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
After further investigation using profiling, we still see high in-use objects in memory that creep up over an extended time. It looks like each call to bufio.NewReader allocates a new 4mb byte[] which is never cleaned up correctly.
This PR moves the bufio.Reader to the the reader struct and reuses it when processing packet data.
Short description of the changes
NewTcpReader
Reset
with the new data.Note: We do not cache the io.Reader as this doesn't hold onto the underlying []byte and is cleaned up as expected. See the image above for
bytes.NewReader
.How to verify that this has the expected result
Memory consumption over an extended period is more stable and does not incrementally creep up.