Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: agent version used in build so gha properly evaluates env var #201

Closed
wants to merge 14 commits into from
Closed

fix: agent version used in build so gha properly evaluates env var #201

wants to merge 14 commits into from

Commits on Sep 18, 2023

  1. try different variable in case gha uses it 

    Co-authored-by: Robb Kidd <robbkidd@honeycomb.io>
    @JamieDanielson @robbkidd
    JamieDanielson and robbkidd committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    ca4d958 View commit details
    Browse the repository at this point in the history

  2. make version (for debugging) 

    Co-authored-by: Robb Kidd <robbkidd@honeycomb.io>
    @JamieDanielson @robbkidd
    JamieDanielson and robbkidd committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    03f43c2 View commit details
    Browse the repository at this point in the history

  3. retry with nonsense env var 

    if this somehow still doesnt work with i_made_this_up...

(╯°□°）╯︵ ┻━┻

Co-authored-by: Robb Kidd <robbkidd@honeycomb.io>
    @JamieDanielson @robbkidd
    JamieDanielson and robbkidd committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    57c7eb0 View commit details
    Browse the repository at this point in the history

  4. hardcode string for version 

    - take shell and git out of the equation
- make version uses variable with hardcoded string
- make build uses hardcoded string

Co-authored-by: Robb Kidd <robbkidd@honeycomb.io>
    @JamieDanielson @robbkidd
    JamieDanielson and robbkidd committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    e77bc5f View commit details
    Browse the repository at this point in the history

  5. remove cache and try debug

    @JamieDanielson
    JamieDanielson committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    4dc05ad View commit details
    Browse the repository at this point in the history

  6. hardcoded strings work; revert env vars for now

    @JamieDanielson
    JamieDanielson committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d0a93c5 View commit details
    Browse the repository at this point in the history

  7. inject release version into image build 

    Adds RELEASE_VERISON as an optional build argument to the Dockerfile.

RELEASE_VERSION is still computed by the Makefile.

For the docker-build make target, pass in the version with --build-arg.

For the docker/build-and-publish GitHub Action in our Release workflow,
compute the RELEASE_VERSION with our make version target, set it in the
environment for the workflow per GitHub docs[1], and pass in the arg
with the build-args: key for the action.

[1] https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files
    @robbkidd
    robbkidd committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    f1422c4 View commit details
    Browse the repository at this point in the history

  8. use = not ::, silly

    @robbkidd
    robbkidd committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    2e7cf9c View commit details
    Browse the repository at this point in the history

  9. show the version to be built in workflow output

    @robbkidd
    robbkidd committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    e6191a8 View commit details
    Browse the repository at this point in the history

  10. update the PR workflow, too!

    @robbkidd
    robbkidd committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    6cd716d View commit details
    Browse the repository at this point in the history

  11. what even is going on?

    @robbkidd
    robbkidd committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    135ba79 View commit details
    Browse the repository at this point in the history

  12. just put the command in the workflow YAML 

    even though it breaks my heart

Co-authored-by: JamieDanielson <jamieedanielson@gmail.com>
    @robbkidd @JamieDanielson
    robbkidd and JamieDanielson committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    47fda16 View commit details
    Browse the repository at this point in the history

  13. remove debug flag, not used

    @JamieDanielson
    JamieDanielson committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    c8ba3cd View commit details
    Browse the repository at this point in the history

  14. try manually fetching tags

    @JamieDanielson
    JamieDanielson committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    ab86d31 View commit details
    Browse the repository at this point in the history