Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set error field if HTTP status >= 400 #248

Merged
merged 2 commits into from Sep 27, 2023
Merged

feat: set error field if HTTP status >= 400 #248

merged 2 commits into from Sep 27, 2023

Conversation

robbkidd
Copy link
Member

@robbkidd robbkidd commented Sep 27, 2023 •
edited

Short description of the changes

Distinguish between server (status >= 500) and client (500 > status >= 400) errors by noting that in the value for the error field instead of only marking error as true or false.

How to verify that this has the expected result

@robbkidd
feat: set error field if HTTP status >= 400
242f760 
Distinguish between server and client errors by noting that in the value
for the error field instead of only marking error as true or false.
@robbkidd
update test to expect error field
372c029
@robbkidd robbkidd marked this pull request as ready for review September 27, 2023 18:27
@robbkidd robbkidd requested a review from a team as a code owner September 27, 2023 18:27
@robbkidd robbkidd added the type: enhancement New feature or request label Sep 27, 2023
@robbkidd robbkidd self-assigned this Sep 27, 2023
JamieDanielson
JamieDanielson approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Was able to confirm usage with greeting service (expects greeting) curl localhost:7777/greetings and echoserver curl http://localhost:80\?echo_code\=500

client and server errors

@robbkidd robbkidd merged commit 18b10b1 into main Sep 27, 2023
3 checks passed
@robbkidd robbkidd deleted the robb.set-error-if-http-error branch September 27, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieDanielson JamieDanielson JamieDanielson approved these changes

Assignees

@robbkidd robbkidd

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robbkidd @JamieDanielson