feat: Add config option to set additional attributes on all events #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
changed the title
There was a problem hiding this comment.
This is great! My only thought... naming is hard. I'm thinking we may want something like ADDITIONAL_ATTRIBUTES or something without agent in the name, because it's not about the agent per se. k8s agent uses additionalFields but I think attributes is more of the term we'd be leaning toward as it gets closer to OTel naming schemes. What do you think?
|
Sure, happy to use additional attributes instead 👍🏻 |
MikeGoldsmith
changed the title
JamieDanielson
pushed a commit
that referenced
this pull request
Oct 4, 2023
## Which problem is this PR solving? Prepares the v0.0.20-alpha release. ## Short description of the changes - Add changelog entry - Update agent version **Note**: The release includes references to the following PRs that are not merged yet: - #259 - #266 I've also used the @ notation for contributor names to see if GitHub automatically links them. ## How to verify that this has the expected result A new release of the agent can be published.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When deploying the agent in multiple clusters, telemetry from each cluster get mixed together and there is no easy way to separate it. There are other use cases of setting per-cluster values too, eg SHA, cloud provider, etc.
This PR adds a configuration option to set a collection of key-value pairs that will be set on all events. For example; cluster-name=dev would add the field cluster-name with a value of dev.
Short description of the changes
ADDITIONAL_ATTRIBUTESenv var using new env look up funcHow to verify that this has the expected result
When additional attributes are provided, they are added to all events.