Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: capture more types of HTTP requests #276

Merged
merged 4 commits into from Oct 12, 2023
Merged

feat: capture more types of HTTP requests #276

merged 4 commits into from Oct 12, 2023

Conversation

robbkidd
Copy link
Member

@robbkidd robbkidd commented Oct 10, 2023 •
edited

Which problem is this PR solving?

Short description of the changes

  • Extend list of supported HTTP methods in the bpf filter used to capture network activity to include HEAD, OPTIONS, PATCH, TRACE and CONNECT
  • Breaks up the components that make up the capture filter. Lots of words written about what the pieces do.
    • This is ripe for extraction into an HTTP-flavored subpackage.
  • Tests for the filter generator

How to verify that this has the expected result

More HTTP methods will be captured and have events created from.

@robbkidd robbkidd requested a review from a team as a code owner October 10, 2023 21:43
MikeGoldsmith
MikeGoldsmith previously approved these changes Oct 11, 2023
View reviewed changes
MikeGoldsmith
MikeGoldsmith reviewed Oct 11, 2023
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
@robbkidd robbkidd self-assigned this Oct 11, 2023
@robbkidd robbkidd added the type: enhancement New feature or request label Oct 11, 2023
@robbkidd robbkidd dismissed MikeGoldsmith’s stale review October 11, 2023 19:06

I made a lot more changes than only the loop Mike recommended. I think they warrant a re-review. ❤️

@robbkidd
add the rest of the HTTP methods to capture filter
5322de0
@robbkidd
encode filter matches from original strings
e118b19 
The inlined hex values could be a little too much "trust the comments!"
At least one incorrect set of hex values were introduced (but not
committed) during development. The filter is only built once at startup,
so this change prioritizes communicating what's happening over
performance.
@robbkidd
move config testing into config package
e60df61 
Sets the stage for being able to write tests for private functions.
@robbkidd
refactor pcap filter generation
f8124e8 
Breaks up the components that make up the capture filter. Also, lots of
words written about what the pieces do.

And tests!
@robbkidd robbkidd merged commit b29a3fb into main Oct 12, 2023
4 checks passed
@robbkidd robbkidd deleted the robb.more-http-verbs branch October 12, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@robbkidd robbkidd

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture all standard HTTP methods
2 participants
@robbkidd @MikeGoldsmith