fix: add headers to honeycomb event #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
http.request.headers
andhttp.response.headers
and accompanying unit tests. feat: Add configurable list of HTTP headers to extract #277 added all the logic for configuring theHTTP_HEADERS
to be extracted, and this PR adds the headers to the actual event to be sent to Honeycomb.This is the smaller implementation mentioned in the issue. We could (/should?) have individual attributes for each key, but I figured this could be a faster fix to start since we've already published with the expectation of HTTP_HEADERS working.
How to verify that this has the expected result
Run the agent with something like the example greeting service and see the attributes in Honeycomb.
The default captures just the User-Agent:
http.request.headers
"{\"User-Agent\":[\"Go-http-client/1.1\"]}"
http.response.headers
"{}"
If for example the list includes
"User-Agent,Accept-Encoding,Content-Length,Content-Type"
, the result looks like this:http.request.headers
"{\"Accept-Encoding\":[\"gzip\"],\"User-Agent\":[\"Go-http-client/1.1\"]}"
http.response.headers
"{\"Content-Length\":[\"12\"],\"Content-Type\":[\"text/plain; charset=utf-8\"]}"