Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add headers to honeycomb event #289

Merged
merged 1 commit into from Oct 19, 2023
Merged

Conversation

JamieDanielson
Copy link
Contributor

@JamieDanielson JamieDanielson commented Oct 18, 2023

Which problem is this PR solving?

Short description of the changes

This is the smaller implementation mentioned in the issue. We could (/should?) have individual attributes for each key, but I figured this could be a faster fix to start since we've already published with the expectation of HTTP_HEADERS working.

How to verify that this has the expected result

Run the agent with something like the example greeting service and see the attributes in Honeycomb.

The default captures just the User-Agent:

  • http.request.headers
    • example: "{\"User-Agent\":[\"Go-http-client/1.1\"]}"
  • http.response.headers
    • example: "{}"

If for example the list includes "User-Agent,Accept-Encoding,Content-Length,Content-Type", the result looks like this:

  • http.request.headers
    • example: "{\"Accept-Encoding\":[\"gzip\"],\"User-Agent\":[\"Go-http-client/1.1\"]}"
  • http.response.headers
    • example: "{\"Content-Length\":[\"12\"],\"Content-Type\":[\"text/plain; charset=utf-8\"]}"

@JamieDanielson JamieDanielson requested a review from a team as a code owner October 18, 2023 19:59
@JamieDanielson JamieDanielson self-assigned this Oct 18, 2023
@JamieDanielson JamieDanielson added the type: bug Something isn't working label Oct 18, 2023
@JamieDanielson JamieDanielson merged commit 2769b30 into main Oct 19, 2023
5 checks passed
@JamieDanielson JamieDanielson deleted the jamie.add-headers-to-event branch October 19, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events in Honeycomb don't include specified headers
2 participants