feat: Add OTLP handler to send events using OpenTelemetry #290
Conversation
…to mike/otel # Conflicts: # smoke-tests/deployment.yaml
MikeGoldsmith
changed the title
There was a problem hiding this comment.
I'm soo excited for this! Amazing work Mike. I left some comments mostly related to keeping telemetry parity with what's currently available with the libhoney event implementation. That said, this works and since it's not yet on by default, I'm somewhat inclined to handle some of the items in the follow-up if they prove to be more time-intensive - especially things that aren't really spec'd out like the headers and newer HTTP attributes.
JamieDanielson
added
the
status: revision needed
Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
MikeGoldsmith
force-pushed
the
mike/otel
branch
from
0f8b7a7
to
7cc7c6c
Compare
MikeGoldsmith
removed
the
status: revision needed
| prefix = "http.response.header" | ||
| } | ||
| attrs := []attribute.KeyValue{} | ||
| for key, val := range header { |
There was a problem hiding this comment.
I was working on a test for this and ended up iterating through one more time to get clean strings for header values. I'm not sure if that's right but it did show up more cleanly as attribute values.
Also I adjusted to further match the recommendation of the semantic conventions, which is to lowercase the key and replace hyphens with underscores.
What do you think? 8537b56
There was a problem hiding this comment.
Small change needed in setting the response headers, and then a suggestion based on more closely following the semconv recommendation. I included those changes and some adjustments to the smoke test deployment in another branch, let me know what you think!
Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io>
## Which problem is this PR solving? More closely follows sem conv when handing headers in the otel handler. --------- Co-authored-by: JamieDanielson <jamieedanielson@gmail.com>
…ributes (#296) ## Which problem is this PR solving? The OTel semantic conventions for headers is to lowercase and replace `-` with `_` and for each header to be a separate field/attribute. The logic to do the sanitisation was added in #290 for just the OTel handler. This PR moves it to a utility func that both the OTel and libhoney handlers can use. ## Short description of the changes - Move sanitisation logic to shared utility func - Use new func in both otel and libhoney handlers - Update both handler tests - Add `-count=1` to test command to clear cache on test runs ## How to verify that this has the expected result Both libhoney and OTel handlers sanitise headers and add each header as a separate field / attribute. --------- Co-authored-by: JamieDanielson <jamieedanielson@gmail.com>
… HTTP events (#293) ## Which problem is this PR solving? Updates the OTel handler to try and detect trace context from a HTTP request's traceparent header if present. Based on the this PR: - #290 ## Short description of the changes - Add new func to otel handler to extract trace context from request header as use as parent span context if present - Add unit test to verify extract works - Update shared handler func that creates test http events to accept custom header - Add `Traceparent` to default headers and document in README - Add `net.component` resource attribute to prevent agent span's from participating as a full-fledged service within a Honeycomb service map ## How to verify that this has the expected result Nothing by default. If the otel handler is used and a HTTP request is captured that contains a trace parent header, the span the agent creates will use the same trace context --------- Co-authored-by: Jamie Danielson <jamiedanielson@honeycomb.io> Co-authored-by: Robb Kidd <robbkidd@honeycomb.io> Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
Which problem is this PR solving?
Adds option of sending events using OpenTelemetry formatted data (OTLP). Includes a new config option that defaults to libhoney (current export format).
Short description of the changes
HANDLER_TYPEthat defaults tolibhoneyotelHow to verify that this has the expected result
No change by default. When setting the new env var to
otel, events are sent to Honeycomb using OTLP instead of libhoney.