fix: use ValidatedSetSelector to reduce memory usage in k8s client #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Bond <danbond@protonmail.com>
Signed-off-by: Dan Bond <danbond@protonmail.com>
loshz
changed the title
MikeGoldsmith
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
When looking through the documentation for the selector matching functionality, I noticed a comment about the underlying data being copied due to it being treated as potentially mutable.
We call the
GetServiceForPodmethod of the cached k8s client at least twice per event when sending Honeycomb events and when creating spans in the OTEL handler. This means the same label selector values for both source and destination events are being copied a total of 4 times.This PR updates the usage of the cache to use a
ValidatedSetSelectorwhich implements aMatchesmethod that does not copy.How to verify that this has the expected result
If possible, we should run a debug build in a testing environment and compare the total RAM usage to the figures shown in the graph attached to the original issue.