Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: update codeowners to pipeline #325

Merged
merged 3 commits into from
Dec 11, 2023
Merged

maint: update codeowners to pipeline #325

merged 3 commits into from
Dec 11, 2023

Conversation

JamieDanielson
Copy link
Contributor

No description provided.

@JamieDanielson JamieDanielson requested a review from a team December 8, 2023 16:12
@JamieDanielson JamieDanielson changed the title update codeowners to pipeline maint: update codeowners to pipeline Dec 8, 2023
@JamieDanielson JamieDanielson added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. no-changelog Omit this PR from changelog/release notes. labels Dec 8, 2023
@JamieDanielson
Copy link
Contributor Author

failing test because of different curl versions somewhere in our smoke test setup 😞 will take a look at that

robbkidd
robbkidd approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline. It's for everyone.

@JamieDanielson
Copy link
Contributor Author

Fixed test in #327 , after that merges this can be updated to pass tests

@robbkidd
Copy link
Member

Updated off main. Tests pass. Merginating.

@robbkidd robbkidd merged commit f709019 into main Dec 11, 2023
3 checks passed
@robbkidd robbkidd deleted the jamie.update-codeowners branch December 11, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbkidd robbkidd robbkidd approved these changes

Assignees
No one assigned
Labels
no-changelog Omit this PR from changelog/release notes. type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamieDanielson @robbkidd