Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add k8s metadata to gopacket events #71

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Aug 15, 2023

Which problem is this PR solving?

Connects gopacket data to k8s metadata

Short description of the changes

  • Add k8s util to gather k8s metadata
  • Use k8s util in bpf and gopacket event stream

@pkanal pkanal requested a review from a team August 15, 2023 19:54
@pkanal pkanal changed the title Purvi/k8s metadata ne feat: Add k8s metadata to gopacket events Aug 15, 2023
@pkanal pkanal self-assigned this Aug 15, 2023
@pkanal pkanal added the type: enhancement New feature or request label Aug 15, 2023
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I like that you separated generating k8s attributes into a util that can be used by multiple sources 👍🏻

@pkanal pkanal merged commit 28443ac into main Aug 16, 2023
4 of 5 checks passed
@pkanal pkanal deleted the purvi/k8s-metadata-ne branch August 16, 2023 12:56
@vreynolds vreynolds added this to the Trial with HNY Dogfood milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants