Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: send user agent as a separate attribute #79

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat: send user agent as a separate attribute #79

merged 1 commit into from
Aug 16, 2023

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Aug 16, 2023

Which problem is this PR solving?

Short description of the changes

  • Pulls out User-Agent header and sets the user_agent.original attribute

How to verify that this has the expected result

Screenshot 2023-08-16 at 11 49 55 AM

@pkanal pkanal added the type: enhancement New feature or request label Aug 16, 2023
@pkanal pkanal requested a review from a team August 16, 2023 15:57
@pkanal pkanal self-assigned this Aug 16, 2023
vreynolds
vreynolds approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vreynolds vreynolds merged commit 340bcba into main Aug 16, 2023
4 checks passed
@vreynolds vreynolds deleted the purvi/user-agent branch August 16, 2023 22:19
@vreynolds vreynolds added this to the Trial with HNY Dogfood milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vreynolds vreynolds vreynolds approved these changes

Assignees

@pkanal pkanal

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
Trial with HNY Dogfood
Development

Successfully merging this pull request may close these issues.

Record user agent header as attribute
2 participants
@pkanal @vreynolds