New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring metrics exporter interval and timeout #50

Closed

MikeGoldsmith opened this issue Dec 16, 2022 · 0 comments · Fixed by #52

Assignees

Labels

type: enhancement

Milestone

Contributor

MikeGoldsmith commented Dec 16, 2022

No description provided.

MikeGoldsmith added the type: enhancement label

MikeGoldsmith added this to the Beta milestone

MikeGoldsmith mentioned this issue

bug: Don’t overwrite metrics exporter interval and timeout values #52

Merged

MikeGoldsmith self-assigned this

MikeGoldsmith closed this as completed in #52

MikeGoldsmith added a commit that referenced this issue


          bug: Don’t overwrite metrics exporter interval and timeout values (#52)

a4f69ed

## Which problem is this PR solving?
We should not overwrite the default interval and timeout properties when
configuring meter readers, both when sending over OTLP and debug.
Instead, if the values are not set, the default from the repspective env
var will be used.


[OTEL_METRIC_EXPORT_INTERVAL](https://github.com/open-telemetry/opentelemetry-python/blob/0f9cfdd3b60914e6779aa6d09a58915565d89389/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py#L444)
- defaults is 60 seconds

[OTEL_METRIC_EXPORT_TIMEOUT](https://github.com/open-telemetry/opentelemetry-python/blob/0f9cfdd3b60914e6779aa6d09a58915565d89389/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py#L454)
- defaults 30 seconds

- Closes #50

## Short description of the changes
- Don't set values for interval or timeout when configuring a meter
reader for OTLP or console exporters

## How to verify that this has the expected result
The default interval and timeout is used for meter readers and can be
altered using the appropriate env var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment