Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging setup - Locally #6

Closed
2 tasks done
Tracked by #3
emilyashley opened this issue Dec 1, 2022 · 1 comment
Closed
2 tasks done
Tracked by #3

Packaging setup - Locally #6

emilyashley opened this issue Dec 1, 2022 · 1 comment
Assignees
Milestone

Comments

@emilyashley
Copy link
Contributor

emilyashley commented Dec 1, 2022

We'd like to follow good, modern python packaging guidelines so let's explore what those are.
Before setting packaging and releasing up on PyPI (#7) we're going to want to test it out locally.

This ticket might be done when:

  • We can check out how the packaging works locally and test against it
  • You feel good about the experience of including this module in external code (i.e. EGS)

This might be a good place to start? https://packaging.python.org/en/latest/tutorials/packaging-projects/.
It's worth noting that we're using poetry so best practices might differ from pip recommendations.

@pkanal
Copy link
Contributor

pkanal commented Feb 1, 2023

Looking into packaging with poetrywe have to run poetry build to create the .tar.gz and .whl files. When we publish we should use poetry publish --build to do it all in one step.

For testing I did the following:

  1. Ran make build in honeycomb-opentelemetry-python
  2. Added the tarball package to message-service in example-greeting-service
  3. Imported our package functions and instrumented message-service
  4. Ran message-service to test our distro

EGS branch: honeycombio/example-greeting-service@main...purvi/py-distro-local-packaging

Next steps: use the packaging commands with CircleCI to publish

@pkanal pkanal closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants