New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging Setup - CircleCI + PyPI #7

Closed

Tracked by

emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #82

Closed

Tracked by

Packaging Setup - CircleCI + PyPI #7

emilyashley opened this issue Dec 1, 2022 · 0 comments · Fixed by #82

Assignees

Milestone

Contributor

emilyashley commented Dec 1, 2022

No description provided.

This was referenced Dec 1, 2022

📍 Planning Issue ⬅ 👀 #3

Closed

Packaging setup - Locally #6

Closed

MikeGoldsmith added this to the Beta milestone

pkanal self-assigned this

pkanal mentioned this issue

ci: add build & publish steps to CI #82

Merged

6 tasks

pkanal closed this as completed in #82

pkanal added a commit that referenced this issue


          ci: add build & publish steps to CI (#82)

2800c93

## Which problem is this PR solving?
This PR adds build + packaging support in CI to release
`honeycomb-opentelemetry` on GitHub & PyPI

- Closes #7 

## Short description of the changes
- added `build` step that builds the package into a binary and persists
it for other workflows, runs on all branches / PRs
- added `publish_github` step that takes the artifacts built in the
`build` step and creates a github draft release, only runs on version
tags
- added `publish_pypi` step that takes the artifacts built in the
`build` step and pushes them to PyPI, only runs on version tags
- added `RELEASING.md` instructions

## How to verify that this has the expected result
- [x] [`build` step runs on all
branches](https://app.circleci.com/pipelines/github/honeycombio/honeycomb-opentelemetry-python/202/workflows/6b04cc96-7702-491e-975a-e9e4c6e5440b)
- [x] [`build` step produces artifacts (.whl, .tgz
package)](https://app.circleci.com/pipelines/github/honeycombio/honeycomb-opentelemetry-python/202/workflows/6b04cc96-7702-491e-975a-e9e4c6e5440b/jobs/1051/artifacts)
- [x] `publish_github` step creates a draft release with `build` step
artifacts (cannot verify this until this repo goes public)
- [x] [`publish_github` step only runs on tagged
branches](https://app.circleci.com/pipelines/github/honeycombio/honeycomb-opentelemetry-python/203/workflows/c01843d3-8349-4187-9041-a6ca5c740fd8)
- [x] [`publish_pypi` step pushes to PyPI using artifacts from `build`
step](https://pypi.org/project/honeycomb-opentelemetry/)
- [x] [`publish_pypi` step only runs on tagged
branches](https://app.circleci.com/pipelines/github/honeycombio/honeycomb-opentelemetry-python/203/workflows/c01843d3-8349-4187-9041-a6ca5c740fd8/jobs/1053)

## Open questions
~- Do we want to push the `publish_github` step as is without making the
repo public? We can either make the repo public now, comment out the
`publish_github` step or keep the step and it'll start working whenever
we make the repo public.~

We decided to keep the step and it'll just work once we make the repo
public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment