Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set shell to bash in Makefile to enable unset #154

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix: set shell to bash in Makefile to enable unset #154

merged 1 commit into from
Aug 31, 2023

Conversation

to-json
Copy link
Contributor

@to-json to-json commented Aug 21, 2023

Which problem is this PR solving?

Short description of the changes

sets shell to bash to fix shell builtin behaviour

How to verify that this has the expected result

run make test with a disruptive environment variable that starts with HONEYCOMB_ or OTEL_ set

@to-json to-json requested a review from a team August 21, 2023 22:10
@vreynolds vreynolds added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Aug 22, 2023
@pkanal pkanal self-assigned this Aug 28, 2023
@pkanal pkanal added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Aug 28, 2023
pkanal
pkanal approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@pkanal pkanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@pkanal pkanal changed the title issue #69: set shell to bash in Makefile to enable unset fix: set shell to bash in Makefile to enable unset Aug 31, 2023
@pkanal pkanal merged commit 9f8466f into honeycombio:main Aug 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanal pkanal pkanal approved these changes

Assignees

@pkanal pkanal

Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add way to clear env vars before running tests
3 participants
@to-json @pkanal @vreynolds