Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Add project metadata for license and classifiers #175

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Adds additional project metadata to describe the associated license and python classifiers. This makes it easier for consumers to audit the dependency for usage and requirements.

Short description of the changes

  • Add license and classifiers and entries to pyproject.toml

How to verify that this has the expected result

The new metadata is added to built packages and discoverable once published, eg on pypi.org

@MikeGoldsmith MikeGoldsmith added type: maintenance The necessary chores to keep the dust off. version: bump minor A PR that adds behavior, but is backwards-compatible. labels Feb 6, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this Feb 6, 2024
@MikeGoldsmith MikeGoldsmith requested a review from a team as a code owner February 6, 2024 11:54
classifiers = [
"Development Status :: 4 - Beta",
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache Software License",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 I wish this was "Apache License, Version 2.0" but that's not the string the ecosystem appears to expect.

Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's classifed

@MikeGoldsmith MikeGoldsmith merged commit e5e8a8d into main Feb 6, 2024
3 checks passed
@MikeGoldsmith MikeGoldsmith deleted the mike/package-metadata branch February 6, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package is missing license metadata - add key and trove classifiers?
2 participants