Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel: prep v0.4.0b0 release #181

Merged
merged 3 commits into from
Mar 7, 2024
Merged

rel: prep v0.4.0b0 release #181

merged 3 commits into from
Mar 7, 2024

Conversation

brookesargent
Copy link
Contributor

Which problem is this PR solving?

Prep the 0.4.0 release (wasn't totally sure if this should be a or b)

@brookesargent brookesargent marked this pull request as ready for review March 6, 2024 19:53
@brookesargent brookesargent requested a review from a team as a code owner March 6, 2024 19:53
@brookesargent brookesargent added merge at will Reviewer can merge the PR once reviewed. no-changelog Omit this PR from changelog/release notes. labels Mar 6, 2024
@brookesargent brookesargent self-assigned this Mar 6, 2024
@VinozzZ
Copy link

VinozzZ commented Mar 6, 2024

I'm curious as well about whether this should be a prepatch(b) or prerelease(a) @JamieDanielson

Copy link
Contributor

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Hm. The versioning in prereleases of python seem to be a bit funky, and this tool we use for poetry version doesn't seem to work well with our suffixes. We think we should've had 0.3.0b0 as our previous release, which would mean a beta instead of alpha, similar to how upstream otel-python appears to version their beta/experimental packages.

So let's make this v0.4.0b0.

@JamieDanielson
Copy link
Contributor

I'll update the releasing doc to remove that versioning section in a follow-up PR.

@brookesargent brookesargent changed the title rel: prep v0.4.0a0 release rel: prep v0.4.0b0 release Mar 7, 2024
@brookesargent
Copy link
Contributor Author

🤔 Hm. The versioning in prereleases of python seem to be a bit funky, and this tool we use for poetry version doesn't seem to work well with our suffixes. We think we should've had 0.3.0b0 as our previous release, which would mean a beta instead of alpha, similar to how upstream otel-python appears to version their beta/experimental packages.

So let's make this v0.4.0b0.

Thanks for looking into it! Done!

@MikeGoldsmith MikeGoldsmith dismissed JamieDanielson’s stale review March 7, 2024 16:58

Updated version number as requested

@brookesargent brookesargent merged commit 67ae857 into main Mar 7, 2024
3 checks passed
@brookesargent brookesargent deleted the brooke.prep-v0.4.0a0 branch March 7, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge at will Reviewer can merge the PR once reviewed. no-changelog Omit this PR from changelog/release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants