maint: Permit updates of indirect dependencies #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version requirements should permit consumers to use SemVer-compatible updates of the upstream opentelemetry packages, rather than locking specific versions.
MikeGoldsmith
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Hi @BatmanAoD - thank you for the PR.
Looking at the poetry dependency specification docs, I think being less restrictive makes sense here. Updating to ^1.22.0 effectively limits the dependency versions to >=1.22.0 and <2.0.0. We need to be more careful with major updates so I think works well.
I made one small change which was to re-run poetry lock --no-update with a newer version of poetry as it doesn't add the category field in dependencies anymore.
MikeGoldsmith
added
the
type: maintenance
MikeGoldsmith
added
the
version: bump patch
MikeGoldsmith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version requirements should permit consumers to use SemVer-compatible updates of the upstream opentelemetry packages, rather than locking specific versions.
Which problem is this PR solving?
The
opentelemetry-sdkversion requirement is overly strict. This is preventing me from using a different dependency that specifiesopenetelemetry-sdk = "^1.23.0".Short description of the changes
Use
^to specify that SemVer-compatible updates toopentelemetry-sdkpackages are permitted.How to verify that this has the expected result
Import this package together with
opentelemetry-sdk = "1.23.0".