doc: audit of docstrings for dev-friendliness & relevance #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
the
type: maintenance
emilyashley
force-pushed
the
emash-76
branch
from
c89df3a
to
af6e054
Compare
emilyashley
force-pushed
the
emash-76
branch
from
af6e054
to
483fc02
Compare
pkanal
reviewed
Feb 27, 2023
robbkidd
reviewed
Feb 27, 2023
| @@ -14,19 +14,27 @@ | |||
| OTEL_SERVICE_NAME | |||
| ) | |||
| from grpc import ssl_channel_credentials | |||
| OTEL_SERVICE_VERSION = "OTEL_SERVICE_VERSION" | |||
|
|
|||
| DEBUG = "DEBUG" | |||
There was a problem hiding this comment.
During sync review: let's put these ENV VAR constants and the credential ones near each other with a comment that they are ENV VAR name constants.
robbkidd
reviewed
Feb 27, 2023
| or a TraceIdRatio as 1/N. | ||
|
|
||
| Each of these samplers is ParentBased, meaning it respects | ||
| its parent span's sampling decision. |
There was a problem hiding this comment.
Huge fan! Even though we'll be writing the opposite here, soon. 😀
Co-authored-by: Purvi Kanal <purvikanal@honeycomb.io>
Co-authored-by: Purvi Kanal <purvikanal@honeycomb.io>
pkanal
approved these changes
Feb 27, 2023
emilyashley
added a commit
that referenced
this pull request
Feb 27, 2023
<!-- Thank you for contributing to the project! 💜 Please see our [OSS process document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#) to get an idea of how we operate. --> ## Which problem is this PR solving? - Closes #31 ## Short description of the changes built off of #85 , please review that one first! Only the last 3 commits in this PR are finalizing turning on the linting in CI. ## How to verify that this has the expected result In CircleCI, the linting step should run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
How to verify that this has the expected result