Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update dev docs #87

Merged
merged 3 commits into from
Feb 17, 2023
Merged

docs: update dev docs #87

merged 3 commits into from
Feb 17, 2023

Conversation

robbkidd
Copy link
Member

@robbkidd robbkidd commented Feb 15, 2023 •
edited

Which problem is this PR solving?

Short description of the changes

  • replaces the poetry commands in DEVELOPING with the simpler make variants we've added to the project
  • state minimum Python version in README
  • link to DEVELOPING from README

How to verify that this has the expected result

  • Run all the make commands
  • Run 'em with remake, too

@robbkidd
update dev docs to use make commands
f08d64d 
Our make commands are simpler than the underlying poetry incantations.
@robbkidd robbkidd requested a review from a team February 15, 2023 21:37
@robbkidd robbkidd mentioned this pull request Feb 15, 2023
Closed
4 tasks
@robbkidd robbkidd added this to the Beta milestone Feb 15, 2023
@robbkidd robbkidd changed the title docs: update dev docs to use make commands docs: update dev docs Feb 15, 2023
@robbkidd robbkidd added type: documentation Improvements or additions to documentation no-changelog Omit this PR from changelog/release notes. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Feb 15, 2023
pkanal
pkanal approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@pkanal pkanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

DEVELOPING.md Outdated Show resolved Hide resolved
@robbkidd robbkidd merged commit edeee1f into main Feb 17, 2023
@robbkidd robbkidd deleted the robb.develop-with-make branch February 17, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanal pkanal pkanal approved these changes

Assignees

@robbkidd robbkidd

Labels
no-changelog Omit this PR from changelog/release notes. type: documentation Improvements or additions to documentation version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robbkidd @pkanal