Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move away from a ParentBased sampling approach. #96

Merged
merged 1 commit into from
Mar 6, 2023
Merged

feat: move away from a ParentBased sampling approach. #96

merged 1 commit into from
Mar 6, 2023

Conversation

emilyashley
Copy link
Contributor

@emilyashley emilyashley commented Feb 28, 2023 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Move from Parent-based DEFAULT_ON, DEFAULT_OFF to ALWAYS_OFF, ALWAYS_ON, TraceIdRatioBased Sampling.
  • Update documentation to reflect this change.

How to verify that this has the expected result

@emilyashley emilyashley mentioned this pull request Feb 28, 2023
Closed
@emilyashley emilyashley marked this pull request as ready for review March 6, 2023 16:57
@emilyashley emilyashley requested a review from a team March 6, 2023 16:57
@emilyashley emilyashley self-assigned this Mar 6, 2023
@JamieDanielson JamieDanielson changed the title feat: wip: move away from a ParentBased sampling approach. feat: move away from a ParentBased sampling approach. Mar 6, 2023
@JamieDanielson JamieDanielson added type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible. labels Mar 6, 2023
@emilyashley emilyashley merged commit 63ec5fe into main Mar 6, 2023
@emilyashley emilyashley deleted the emash-non-parent-sampling branch March 6, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@emilyashley emilyashley

Labels
type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeterministicSampler: Parent-based or not?
3 participants
@emilyashley @MikeGoldsmith @JamieDanielson