fix(postgres): report query duration as duration_ms #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per company documentation for auto-recognition for traces: https://docs.honeycomb.io/getting-data-in/tracing/troubleshooting/#honeycomb-is-not-recognizing-my-traces fixes honeycombio#250
robbkidd
added
the
status: oncall
robbkidd
requested changes
Jun 21, 2022
There was a problem hiding this comment.
Because field names are an implied schema for the backend receiving telemetry, we can't rename fields lightly. This will break any queries, triggers, or SLOs for current users of honeytail who care about event duration.
Adding new, better names is great, though! Can you update this PR to keep the old duration field and still add the new duration_ms?
robbkidd
added
the
status: revision needed
pckilgore
commented
Jun 22, 2022
vreynolds
removed
the
status: revision needed
MikeGoldsmith
added
version: bump minor
|
Thank you for the fix, @pckilgore! Our apologies for the hang-time on the re-review after your quick revisions. The maintainers were at an off-site last week and are still working through our backlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per company documentation for auto-recognition for traces: https://docs.honeycomb.io/getting-data-in/tracing/troubleshooting/#honeycomb-is-not-recognizing-my-traces
Which problem is this PR solving?
durationnotduration_ms#250Short description of the changes
duration_msvs.duration