Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildevents prevents forked builds from running on CI #78

Closed
MikeGoldsmith opened this issue Oct 4, 2021 · 1 comment
Closed

Buildevents prevents forked builds from running on CI #78

MikeGoldsmith opened this issue Oct 4, 2021 · 1 comment
Labels
type: bug type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.

Comments

@MikeGoldsmith
Copy link
Contributor

MikeGoldsmith commented Oct 4, 2021 •
edited

Versions

  • Python: N/A
  • Libhoney: main

Steps to reproduce

  1. PRs submitted from a fork will fail because we build events is enabled and requires a CircleCI token which is not provided on forked runs.

Additional context

  • We have removed build events from other repos because of this limitation.

As seen in #77
@MikeGoldsmith MikeGoldsmith added type: bug version: no bump A PR with maintenance or doc changes that aren't included in a release. type: maintenance The necessary chores to keep the dust off. labels Oct 4, 2021
@vreynolds
Copy link
Contributor

Should be fixed by #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeGoldsmith @vreynolds