Bump dependencies for react 15.6 compatibility #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eanakashima
commented
Oct 13, 2017
| You can also use the standalone build by including `react-select.js` and `react-select.css` in your page. (If you do this though you'll also need to include the dependencies.) For example: | ||
| ```html | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react-dom.min.js"></script> |
There was a problem hiding this comment.
Deleted this whole bit because I got annoyed at it matching a grep for older react versions. 🤐
| @@ -1,7 +1,9 @@ | |||
| import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import createReactClass from 'create-react-class'; | |||
There was a problem hiding this comment.
A handful of these classes could be converted to es6 classes inheriting from React.PureComponent but I didn't want to take the time to dig through and figure out which ones. May come back to that if I need to make more changes to do React 16 compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is a bit noisy due to the dist files, but the important bits are:
package.jsonto get deps compatible with 15.5/15.6.node-versionfile to lock in a version where the build script works