maint: Update Husky to handle invalid content type errors #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
version: bump patch
MikeGoldsmith
force-pushed
the
mike/husky-otlp-errors
branch
from
e584949
to
f1a5e0e
Compare
codeboten
reviewed
Feb 29, 2024
| } | ||
| } else { | ||
| // Since we have an invalid content type for an OTLP HTTP response we choose to use to text/plain | ||
| if err := husky.WriteOtlpHttpFailureResponse(w, req, otlpErr); err != nil { |
There was a problem hiding this comment.
is the error here always a content type error?
There was a problem hiding this comment.
No, API key missing or invalid errors are also possible to come through here
There was a problem hiding this comment.
right, the description says it will use plain for content type errors, but this changes the behaviour for all errors?
TylerHelmuth
approved these changes
Feb 29, 2024
Merged
robbkidd
added a commit
that referenced
this pull request
Mar 1, 2024
## Which problem is this PR solving? - Releasing #1019 ## Short description of the changes - update CHANGELOG and RELEASE_NOTES - no documentation updates - no dependency license changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates Husky to v0.25.1 which includes fixes handling invalid content types for OTLP requests.
See the following PR for changes:
NOTE: This PR is based on an unreleased version of husky. We'll wait for husky to be released before merging this fix.
Short description of the changes