Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Classic Ingest Keys #1043

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: support Classic Ingest Keys #1043

merged 1 commit into from
Mar 7, 2024

Conversation

jharley
Copy link
Contributor

@jharley jharley commented Mar 7, 2024 •
edited

Which problem is this PR solving?

We've now released Ingest Keys, but in order for them to work with Classic environments properly we need to update the key detection logic.

Short description of the changes

  • upgrades husky to 0.26.0
  • updates types.IsLegacyAPIKey to use (husky.otlp).IsClassicApiKey

@jharley jharley added type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible. merge at will Reviewer can merge the PR once reviewed. labels Mar 7, 2024
@jharley jharley self-assigned this Mar 7, 2024
@jharley jharley requested a review from a team March 7, 2024 13:03
@jharley jharley marked this pull request as ready for review March 7, 2024 13:14
@jharley jharley requested a review from a team as a code owner March 7, 2024 13:14
kentquirk
kentquirk approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Is it OK if this isn't released for a few weeks?

@jharley
Copy link
Contributor Author

jharley commented Mar 7, 2024 •
edited

Is it OK if this isn't released for a few weeks?

This would hold up the release of Classic support for Ingest Keys, so we'd like to do it sooner rather than later (like, early next week at the latest).

@jharley jharley merged commit 4558dac into main Mar 7, 2024
6 checks passed
@jharley jharley deleted the jharley.classic-ingest-key-support branch March 7, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

@brookesargent brookesargent brookesargent approved these changes

Assignees

@jharley jharley

Labels
merge at will Reviewer can merge the PR once reviewed. type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jharley @kentquirk @brookesargent