Add OTLP ingest #202
Merged
Add OTLP ingest #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
force-pushed
the
mike/otlp
branch
from
14c4cf0
to
3b92a6a
Compare
fix config reload test only atempt to stop grpc server if not nil don't double invoke config in config test
MikeGoldsmith
force-pushed
the
mike/otlp
branch
from
60c36c4
to
73786af
Compare
asdvalenzuela
approved these changes
Jan 8, 2021
vreynolds
reviewed
Jan 12, 2021
|
@MikeGoldsmith I tried to review to the best of my knowledge :)
|
paulosman
approved these changes
Jan 22, 2021
Co-authored-by: Paul Osman <paul@honeycomb.io>
* main:
Add /debug/trace/{traceID} endpoint (#204)
# Conflicts:
# route/route_test.go
asdvalenzuela
approved these changes
Jan 22, 2021
| if len(grpcAddr) > 0 { | ||
| l, err := net.Listen("tcp", grpcAddr) | ||
| if err != nil { | ||
| r.iopLogger.Error().Logf("failed to listen to grpc addr: " + grpcAddr) |
There was a problem hiding this comment.
Do we want to return if there's an error here?
There was a problem hiding this comment.
I think we should fail to start if a grpc address has been set and we're unable to bind to the port. We return if the HTTP server is unable to start. If something is reliant on gRPC running and the process doesn't fail to start, it could look like we're working but would reject gRPC traffic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OTLP ingest support to refinery.
Initially this PR adds ingest support but does not add support for sending events to peer refinery processes or to the Honeycomb ingest API over gRPC and continues to use HTTP/JSON for that communication.
The primary use-case for adding OTLP here is for ingesting spans directly from OTel SDKs and Collector using OTLP over gRPC. This will allow users of OpenTelemetry to send data to refinery without having to use a custom span exporter and instead use the SDK provided OTLP exporter.