Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal duplicated code with Husky #341

Merged
merged 8 commits into from
Nov 29, 2021
Merged

Replace internal duplicated code with Husky #341

merged 8 commits into from
Nov 29, 2021

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented Oct 29, 2021 •
edited

Which problem is this PR solving?

We have duplicated a number of OTLP trace utility functions into refinery from other systems. This PR replaces those duplicated functions with a new utility module husky.

Short description of the changes

  • Remove internal opentelemetry-proto files
  • Add Husky v0.2.0
  • Use husky/otlp and remove duplicated functionality

@MikeGoldsmith MikeGoldsmith requested a review from a team October 29, 2021 15:36
@MikeGoldsmith MikeGoldsmith self-assigned this Oct 29, 2021
@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Oct 29, 2021
@MikeGoldsmith MikeGoldsmith marked this pull request as draft November 1, 2021 13:14
@MikeGoldsmith
use shared errors from husky
d605293
@MikeGoldsmith
Merge branch 'main' of github.com:honeycombio/refinery into mike/husky
aaf4190 
* 'main' of github.com:honeycombio/refinery:
  prepare v1.6.0 release (#348)
  bump libhoney-go to v1.15.6 (#347)
  Use alpine as base image (#343)
  empower apply-labels action to apply labels (#344)
  Add an --interface-names flag (#342)

# Conflicts:
#	go.mod
#	go.sum
@MikeGoldsmith
check for invalid content error
bbc8efd
@MikeGoldsmith
use husky overload to pass body and requestinfo
510bae1
@MikeGoldsmith MikeGoldsmith marked this pull request as ready for review November 29, 2021 19:32
@MikeGoldsmith MikeGoldsmith added the version: bump minor A PR that adds behavior, but is backwards-compatible. label Nov 29, 2021
robbkidd
robbkidd approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy husky

@robbkidd robbkidd merged commit 3eedc48 into main Nov 29, 2021
@robbkidd robbkidd deleted the mike/husky branch November 29, 2021 20:42
@robbkidd robbkidd mentioned this pull request Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbkidd robbkidd robbkidd approved these changes

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeGoldsmith @robbkidd