add a note about reloading the configuration when running within docker #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
approved these changes
May 6, 2022
There was a problem hiding this comment.
Made a small tweak to the wording, but otherwise great. Thanks for the contribution @leviwilson 👍🏻
MikeGoldsmith
added
type: documentation
version: no bump
Merged
kentquirk
added a commit
that referenced
this pull request
May 17, 2022
## 1.14.1 2022-05-16 ### Fixes - Fix crash bug related to sharding (#455) | [@kentquirk](https://github.com/kentquirk) ### Maintenance - bump husky to 0.10.5 (#450) | [@MikeGoldsmith](https://github.com/MikeGoldsmith) - Bump github.com/klauspost/compress from 1.15.2 to 1.15.4 (#451) | dependabot - Bump github.com/tidwall/gjson from 1.14.0 to 1.14.1 (#444) | dependabot - Bump github.com/fsnotify/fsnotify from 1.5.1 to 1.5.4 (#441) | dependabot ### Documentation - add a note about reloading the configuration when running within docker (#448) | [@leviwilson](https://github.com/leviwilson) - README: remove incorrect mention of sending SIGUSR1 to trigger a configuration reload (#447) | [@jharley](https://github.com/jharley)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the documentation regarding the automatic configuration file reloading when running within a docker container, since you need to mount the directory in rather than the file itself in order for viper to see the configuration changes.