Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kafka-receiver): add flags/configs for kafka receiving #988

Open
wants to merge 2 commits into
base: 3.x-work-branch
Choose a base branch
from

Conversation

lizthegrey
Copy link
Member

Which problem is this PR solving?

Short description of the changes

config.md Outdated
@@ -136,6 +136,39 @@ This is the amount of time after which if the http server does not see any activ
- Type: `duration`
- Default: `0s`

### `KafkaBootstrapAddr`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this moved out to its own group rather than just being in the network configuration, and I'd also give it its own config type. If you call the group "Kafka" you can remove that prefix from all of its names; I think you'll probably want an Enabled flag on it as well.

Then, you could consider having a single accessor that returns the entire group, or leave the separate ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lizthegrey lizthegrey marked this pull request as ready for review March 11, 2024 06:52
@lizthegrey lizthegrey requested a review from a team as a code owner March 11, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants