chore: fix license tracking #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.1.0 dropped support for packages that aren't Go modules. That or any later version run against our current repo state will error with: > Package <package> does not have module info. Non go modules projects > are no longer supported. For feedback, refer to > google/go-licenses#128. Pinning our install to v1.0.0 seems to produce the LICENSES output consistent with what the project has been tracking so far.
TylerHelmuth
approved these changes
Feb 1, 2024
robbkidd
added
the
version: no bump
robbkidd
added a commit
that referenced
this pull request
Feb 2, 2024
This reverts commit 52c5f08. The go-licenses@v1.0.0 pin breaks when run in CI. Needs further investigation.
TylerHelmuth
pushed a commit
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
go-licenses v1.1.0 dropped support for packages that aren't Go modules. That or any later version run against our current repo state will result in many dozens of this error:
Short description of the changes
Pinning our install to v1.0.0 seems to produce the LICENSES output consistent with what the project has been tracking so far.