Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add sampler default intervals to docs #995

Merged
merged 2 commits into from
Feb 14, 2024
Merged

docs: Add sampler default intervals to docs #995

merged 2 commits into from
Feb 14, 2024

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Updates refinery rules metadata to include the default intervals for each of the sampler types. rulesmeta.md was updated manually and the other files were re-generated using the conver tool.

Short description of the changes

@MikeGoldsmith MikeGoldsmith added type: documentation version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Feb 14, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this Feb 14, 2024
@MikeGoldsmith MikeGoldsmith requested a review from a team as a code owner February 14, 2024 13:26
@MikeGoldsmith MikeGoldsmith changed the title [docs]: Add sampler default intervals to docs docs: Add sampler default intervals to docs Feb 14, 2024
kentquirk
kentquirk approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awww, you rock. Thank you. After this, the generated file needs to get copied to docs as well in a docs pr.

@MikeGoldsmith MikeGoldsmith merged commit 80fc7da into main Feb 14, 2024
3 checks passed
@MikeGoldsmith MikeGoldsmith deleted the mike/doc-sampler-duration-defaults branch February 14, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: documentation version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: document default intervals for samplers
2 participants
@MikeGoldsmith @kentquirk