Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major updates to the module #18

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

tdarwin
Copy link
Contributor

@tdarwin tdarwin commented Sep 7, 2023

This is a major release of the Refinery Starter Pack Terraform Module There are many many changes

Which problem is this PR solving?

Short description of the changes

  • Now detects missing columns and creates them if they're missing
  • Adds stress_level queries (only if stress_level columns are detected
  • Adds an error log query to the board for seeing sending and peer communications issues
  • Adds a cache ejection query to tell you why traces are being ejected early from the cache
  • Updates Sample Rates queries based on actual sampler columns in use
  • Updates Board to be effective for Refinery v1, v2, and v2 with OTEL metrics
  • Automatically detects what version of Refinery is sending metrics and applies the correct columns into the queries

How to verify that this has the expected result

Give it a try somewhere!

Signed-off-by: Davin Taddeo <davin@honeycomb.io>
Signed-off-by: Davin Taddeo <davin@honeycomb.io>
Signed-off-by: Davin Taddeo <davin@honeycomb.io>
@tdarwin tdarwin added the major significant and breaking changes label Sep 7, 2023
@tdarwin tdarwin self-assigned this Sep 7, 2023
@tdarwin tdarwin requested review from a team as code owners September 7, 2023 16:24
@tdarwin tdarwin changed the title update the entire fucking module Major updates to the module Sep 7, 2023
@tdarwin tdarwin added the ready-for-review PR is ready to be reviewed label Sep 7, 2023
…register in HNY

Signed-off-by: Davin Taddeo <davin@honeycomb.io>
Copy link
Collaborator

@irvingpop irvingpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s land this bird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major significant and breaking changes ready-for-review PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example script to create missing columns
2 participants