Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAVING support #110

Merged
merged 2 commits into from
Feb 1, 2022
Merged

HAVING support #110

merged 2 commits into from
Feb 1, 2022

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Jan 30, 2022

Adds support for "havings". Snuck in a few linter fixes as well 馃檭

Resolves #97

@codecov-commenter
Copy link

Codecov Report

Merging #110 (a6cbda9) into main (0c799cf) will increase coverage by 0.86%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   84.76%   85.62%   +0.86%     
==========================================
  Files          25       25              
  Lines        1693     1795     +102     
==========================================
+ Hits         1435     1537     +102     
  Misses        204      204              
  Partials       54       54              
Impacted Files Coverage 螖
client/query_spec.go 92.59% <100.00%> (+1.48%) 猬嗭笍
client/type_helpers.go 87.50% <100.00%> (+1.78%) 猬嗭笍
honeycombio/data_source_query_specification.go 95.14% <100.00%> (+1.18%) 猬嗭笍
honeycombio/type_helpers.go 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0c799cf...a6cbda9. Read the comment docs.

@jharley jharley merged commit 06686a2 into main Feb 1, 2022
@jharley jharley deleted the jharley.having-support branch February 1, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HAVING support to Query Specification
3 participants