Fix filter value type parsing and depreciate value_* fields #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharley
commented
Feb 9, 2022
| @@ -100,6 +100,11 @@ func testAccCheckBoardExists(t *testing.T, name string) resource.TestCheckFunc { | |||
| return fmt.Errorf("could not find created board: %w", err) | |||
| } | |||
|
|
|||
| for i := range createdBoard.Queries { | |||
There was a problem hiding this comment.
All changes in this file should have happened in #100.
I'm happy to move them to their own commit if you feel that's better.
dstrelau
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing with curl, it seemed if we properly parse-and-coerce the HCL-read string value that this would work fine without the type-specific
value_*filter options while solving #102 in a round about fashion (and providing a much cleaner interface and nicer DX).This also un-depreciates the filter's
valuewhile depreciating all of thevalue_*fields introduced by #29.