fix: query specification - always treat 'in','not-in' filter values as an array #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 83.20% 83.21%
=======================================
Files 62 62
Lines 4168 4170 +2
=======================================
+ Hits 3468 3470 +2
Misses 547 547
Partials 153 153 ☔ View full report in Codecov by Sentry. |
jharley
changed the title
jharley
commented
Feb 21, 2024
| if valueSet { | ||
| return filter, fmt.Errorf(multipleValuesError) | ||
| } | ||
| filter.Value = vb | ||
| filter.Value = v | ||
| } | ||
|
|
||
| if filter.Op == honeycombio.FilterOpIn || filter.Op == honeycombio.FilterOpNotIn { |
There was a problem hiding this comment.
I understand we're doing "it's an in,not-in filter" things in two places at the moment, but this second check is a function of the deprecated value_* options. Once they're removed we can do this all in one place above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in, andnot-infilter values should always be treated as an array. This allows for the possibility of filters likeapp.mything.id not-in 38374