-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only return short version of sensor UUID in the websocket #96
Comments
Hii @glaslos , |
You can just use make or copy the command from here |
Can you check if my approach is correct to address this issue .
|
Yes, that sound about right. Maybe try without defining the Event type too specific, maybe a |
Please check if my snippet is correct and let me know how can i test this , i mean how these endpoints will be called when i run locally go server. afterward i will generate PR. At line I will put this below snippet in action : `// Unmarshal the JSON message into a map
//Helper function which splits into two parts the sensorID by the hyphen |
Yes, this looks good! |
Fixed honeynet#96 Some changes in handler.go file in publishHandler function intersepted msg []byte object decode it , made changes as per requirnments .
I was curious to know , why havn't we implemented Lint , and designed test cases for both Frontend and backend . Let me if maintainers are looking into this field . I would be happy to implement these . |
…ckend Removed .split ('-')[0] from front end code and already added this logic in backend
I will add linting in the GitHub actions in the future. Considering we are only a few people working in this at the moment, we didn't consider it a priority. Same for the testing, right now we do a lot of manual tests before we release. But feel free to add more tests! |
I have made changes as per discussion please review .
Before publishing to the websockets, truncate the sensor UUID to only the first part until the first
-
.Remove truncating from the front-end code.
The text was updated successfully, but these errors were encountered: